Forum: Bugs and Issues

This forum is specific to reporting bugs and issues with the framework.
-10-5Prev| 3 / 49 |Next+5+10

Typo in QFileAssetBase dlgFileAsset_Upload function?

thread: 5 messages  |  last: a year ago  |  started: saturday, april 3, 2010, 4:37 pm pdt

 
 

#1  |  Gaspar Attila (Odorheiu Secuiesc, RO) Romania
Saturday, April 3, 2010, 4:37 PM PDT

Hi,

In QFileAssetBase.class.php on line 71:


$this->dlgFileAsset->ShowError($this->strUnacceptableMessage . ' 1');

and in line 75:


$this->dlgFileAsset->ShowError($this->strUnacceptableMessage . ' 2');

the concatenated '1' or '2' appear when an error occured.


This is a typo (bug), or not?

Attila

#2  |  Mike Ho (Sunnyvale, CA) United States of America Qcodo Administrator
Tuesday, April 6, 2010, 5:31 PM PDT

oops... yeah, it shouldn't be there.  Could you open up a ticket ofr this in the issue tracker?  Thanks. =)

#3  |  Gaspar Attila (Odorheiu Secuiesc, RO) Romania
Thursday, April 8, 2010, 5:21 PM PDT

Ticket opened, here is: http://www.qcodo.com/issues/view.php/61

#4  |  Zbyszek Czarnecki (Warsaw, PL) Poland
Thursday, April 15, 2010, 5:10 AM PDT

I went ahead and made a patch for merging:
http://github.com/klucznik/qcodo/commit/8bcffda95341e3708b8a85cd4d0161d4e5949f8d

#5  |  Mike Ho (Sunnyvale, CA) United States of America Qcodo Administrator
Wednesday, April 21, 2010, 5:53 PM PDT

awesome.  GIT is pretty cool (just played with git-cherry-pick as you suggested)

Looks like it's working great.  Thanks!


 
 

John 3:16  •  Romans 12:1-8
Copyright © 2005 - 2012, Quasidea Development, LLC
This open-source framework for PHP is released under the terms of The MIT License.