QDataGridRowStyle Height set not working.

thread: 4 messages  |  last: a year ago  |  started: wednesday, april 14, 2010, 10:07 pm pdt


#1  |  mitunya (Japan) Japan
Wednesday, April 14, 2010, 10:07 PM PDT

Hi,

QDataGridRowStyle Height not working.
please change.

Thank you.

--


Qcodo Version : 0.4.14

some php
--
   $o = $this->objdtg->RowStyle ;
   $o->Height = 80 ;
--

Qcode puts
--
<div id=“c2_ctl” style=“display:inline;”><table id=“c2” class=“datagrid” cellpadding=“0” cellspacing=“0” border=“0” >
<thead>
 <tr id=“c2_rowh” style=“height:80pxpx;” >
                                ~~~~~~~
--


Patch
--
diff -pcr QDataGridRowStyle.class.php.org QDataGridRowStyle.class.php
* QDataGridRowStyle.class.php.org     Tue Mar 16 02:35:21 2010
- QDataGridRowStyle.class.php Thu Apr 15 13:35:49 2010
*************
* 112,120 **
 
                       if ($this->strHeight) {
                               if (is_numeric($this->strHeight))
-                                       $strStyle .= sprintf(“height:%s;”, $this->strHeight);
-                               else
                                       $strStyle .= sprintf(“height:%spx;”, $this->strHeight);
                       }
                       if ($this->strForeColor)
                               $strStyle .= sprintf(“color:%s;”, $this->strForeColor);
- 112,120 --
 
                       if ($this->strHeight) {
                               if (is_numeric($this->strHeight))
                                       $strStyle .= sprintf(“height:%spx;”, $this->strHeight);
+                               else
+                                       $strStyle .= sprintf(“height:%s;”, $this->strHeight);
                       }
                       if ($this->strForeColor)
                               $strStyle .= sprintf(“color:%s;”, $this->strForeColor);
---

#2  |  Zbyszek Czarnecki (Warsaw, PL) Poland
Thursday, April 15, 2010, 5:07 AM PDT

I went ahead and made patch for merging:

http://github.com/klucznik/qcodo/commit/4a774e580c2577130b7c74574e7833d88807037c

#3  |  mitunya (Japan) Japan
Thursday, April 15, 2010, 6:52 PM PDT

Thank you.

#4  |  Mike Ho (Sunnyvale, CA) United States of America Qcodo Administrator
Wednesday, April 21, 2010, 5:55 PM PDT

Thanks Zbyszek... changes committed to core.



Copyright © 2005 - 2012, Quasidea Development, LLC
This open-source framework for PHP is released under the terms of The MIT License.